RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]
Alan Bateman
alanb at openjdk.org
Wed Dec 6 12:26:36 UTC 2023
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea <dl at openjdk.org> wrote:
>> This update cascades timeouts to trim subsequent workers after the first keepAlive inactive period.
>
> Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into JDK-8319662
> - Remove unnecessary re-interrupt
> - Merge branch 'openjdk:master' into JDK-8319662
> - Reduce oversignalling and contention; add test
> - Revert 2 lines in method scan
> - Merge branch 'openjdk:master' into JDK-8319662
> - Split up method awaitWork; other associated changes.
> - Merge branch 'openjdk:master' into JDK-8319662
> - tweak cascades; reinstate an @Contended; resolve JDK-8319498
> - Support cascading idle timeouts
I've done some testing with the latest changes. The changes to trimming workers looks okay to me. When Viktor is done reviewing then I think we should integrate this.
-------------
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16725#pullrequestreview-1767414023
More information about the core-libs-dev
mailing list