RFR: 8321180: Condition for non-latin1 string size too large exception is off by one [v3]

Raffaello Giulietti rgiulietti at openjdk.org
Sat Dec 9 16:42:16 UTC 2023


On Fri, 8 Dec 2023 22:35:30 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> In the compact string implementation of non-latin1 (UTF16) strings the length is constrained by VM implementation limit on the size a byte array that can be allocated. To produce a useful exception the implementation checks the string size against the maximum byte array size. The exception message is correct
>> 
>> "UTF16 String size is " + len + ", should be less than or equal to " + MAX_LENGTH
>> 
>> The code should match the message, otherwise the exception thrown is: 
>> 
>> java.lang.OutOfMemoryError: Requested array size exceeds VM limit
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplify and clarify test data array creation

Marked as reviewed by rgiulietti (Reviewer).

LGTM

-------------

PR Review: https://git.openjdk.org/jdk/pull/17008#pullrequestreview-1773751297
PR Comment: https://git.openjdk.org/jdk/pull/17008#issuecomment-1848549411


More information about the core-libs-dev mailing list