RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted [v9]
Sergey Tsypanov
stsypanov at openjdk.org
Mon Dec 11 19:58:27 UTC 2023
On Mon, 11 Dec 2023 14:54:37 GMT, Markus KARG <duke at openjdk.org> wrote:
>> Sergey Tsypanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>>
>> - Merge branch 'master' into 8320971
>> - 8320971: Rename method
>> - 8320971: Extract utility class
>> - 8320971: Rearrange code
>> - 8320971: Rewrite comment
>> - 8320971: Use same approach as BAOS
>> - Merge branch 'master' into 8320971
>> - 8320971: Add test
>> - 8320971: Trust any OutputStream from java.*
>> - 8320971: Use BufferedInputStream.class.getPackageName()
>> - ... and 1 more: https://git.openjdk.org/jdk/compare/2ac25f70...2df52c72
>
> src/java.base/share/classes/java/io/IOStreams.java line 1:
>
>> 1: /*
>
> Please fix Whitespace errors. Thanks. :-)
I've just copy-pasted the header from another class. How should I fix it?
> src/java.base/share/classes/java/io/IOStreams.java line 39:
>
>> 37: * <pre>
>> 38: * - the reference to {@code byte[]} is not kept within the class
>> 39: * - the argument of {@link OutputStream#write(byte[])}} and {@link OutputStream#write(byte[], int, int)}} is not modified within the methods
>
> `- the byte[] is not read outside of the given bounds`
Added
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16879#discussion_r1423051206
PR Review Comment: https://git.openjdk.org/jdk/pull/16879#discussion_r1423052717
More information about the core-libs-dev
mailing list