RFR: 6230751: [Fmt-Ch] Recursive MessageFormats in ChoiceFormats ignore indicated subformats [v4]
Naoto Sato
naoto at openjdk.org
Tue Dec 12 00:36:32 UTC 2023
On Thu, 7 Dec 2023 22:15:51 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which updates an incorrect code example in _java/text/ChoiceFormat_.
>>
>> ChoiceFormat (and MessageFormat) provide an example of how to produce a pattern that supports singular and plural forms. The ChoiceFormat example is incorrect, as recursive MessageFormats produced by a ChoiceFormat subformat only recognize subformats defined through the MessageFormat pattern syntax, not through the subformats contained within the top level MessageFormat.
>>
>> In the original example,
>> `Format[] testFormats = {fileform, null, NumberFormat.getInstance()};` could have been replaced with
>> `Format[] testFormats = {fileform, null, new ChoiceFormat("0#BROKEN")};` and the original output would have been the same.
>>
>> This PR replaces the example with the one used in MessageFormat, which is correct.
>>
>> This PR also includes a drive-by fix to remove leftover `<blockquote>`s from a previous `@snippet` conversion.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> shorten wording
Marked as reviewed by naoto (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/16891#pullrequestreview-1776397562
More information about the core-libs-dev
mailing list