RFR: 8321480: ISO 4217 Amendment 176 Update [v3]
Naoto Sato
naoto at openjdk.org
Tue Dec 12 19:40:33 UTC 2023
On Mon, 11 Dec 2023 22:15:42 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which incorporates the ISO 4217 Amendment 176 Update. As the replacement of `ANG` to `XCG` won't occur until 2025, this change does not need to go into JDK22. `HR` was also updated to remove the past cutover dates.
>>
>> This update also demonstrated that `Currency::getAvailableCurrencies` may return a future currency that should not be returned. _GenerateCurrencyData.java_ was updated to ensure such currencies are not added to the other currency list.
>>
>> Additionally, this change also converted a parameterized test to a normal JUnit test, due to output overflow.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> remove redundant conditionals
LGTM
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17023#pullrequestreview-1778307137
More information about the core-libs-dev
mailing list