RFR: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled [v2]

Aleksei Voitylov avoitylov at openjdk.org
Wed Dec 13 11:49:39 UTC 2023


On Tue, 12 Dec 2023 19:11:43 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Aleksei Voitylov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> test/jdk/java/lang/String/Chars.java line 50:
> 
>> 48:             testChars(cc, ccExp);
>> 49:             testCharsSubrange(cc, ccExp);
>> 50:             testIntsSubrange(ccExp);
> 
> Please also add the same call after line 74 to apply the test to the surrogates case.
> (As suggested by @rgiulietti in https://github.com/openjdk/jdk/pull/17066)

Just pulled the update from that branch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17057#discussion_r1425241518


More information about the core-libs-dev mailing list