Integrated: 8321400: java/foreign/TestStubAllocFailure.java fails with code cache exhaustion

Jorn Vernee jvernee at openjdk.org
Wed Dec 13 17:39:48 UTC 2023


On Mon, 11 Dec 2023 13:01:25 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Improve the test by being more lenient to related code cache exhaustion errors. The important thing is that we don't terminate with a fatal error, which the new code now checks for explicitly. The check for that is based on what is done by `./test/hotspot/jtreg/runtime/ErrorHandling/HsErrFileUtils.java` .
> 
> The existing `UpcallTestHelper.Output` class that was previously used to assert on stdout/stderr contents did not have the capability to look for patterns in the output. So, I've taken the opportunity to replace it with the more canonical `OutputAnalyzer` which comes from the test library.
> 
> Finally, I've also added back the test for downcall stub allocation failure which was removed as part of the initial patch because it was too inconsistent [1]. With the new approach, it should pass reliably as well.
> 
> Testing: `jdk_foreign`  suite (which contains all the affected tests)
> 
> [1]: https://github.com/openjdk/jdk/pull/16311/commits/9a1360598a91871ce6ec48330849c0e4e0279c64

This pull request has now been integrated.

Changeset: 7ece9e90
Author:    Jorn Vernee <jvernee at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7ece9e90c0198f92cdf8d620e346c4a9832724cd
Stats:     106 lines in 7 files changed: 47 ins; 42 del; 17 mod

8321400: java/foreign/TestStubAllocFailure.java fails with code cache exhaustion

Reviewed-by: mcimadamore

-------------

PR: https://git.openjdk.org/jdk/pull/17056


More information about the core-libs-dev mailing list