RFR: JDK-8319626: Override toString() for ZipFile [v8]

Eirik Bjorsnos duke at openjdk.org
Wed Dec 13 18:38:46 UTC 2023


On Mon, 11 Dec 2023 05:47:33 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) which overrides and provides an implementation of `toString()` in _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8319626
>  - break line
>  - reflect review: change impl to store field name
>  - drop additional specification
>  - drop 2nd paragraph
>  - return base name, not full path
>  - shorten wording
>  - reflect review: use separator, clarify spec
>  - reflect review: change string value and drop spec
>  - init

I'm seeing the `ZipSourceCache` fail on GHA on `windows-x64`:


FAILED     ZipSourceCache::testKeySourceMapping 'testKeySourceMapping()'
java.nio.file.FileSystemException: 1702471080605-bug8317678.zip: The process cannot access the file because it is being used by another process
	at java.base/sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:92)
	at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103)
	at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:108)
	at java.base/sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:273)
	at java.base/sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(AbstractFileSystemProvider.java:109)
	at java.base/java.nio.file.Files.deleteIfExists(Files.java:1191)
	at ZipSourceCache.cleanup(ZipSourceCache.java:65)


Build summary: https://github.com/eirbjo/jdk/actions/runs/7194395508

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16643#issuecomment-1854508435


More information about the core-libs-dev mailing list