RFR: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable [v3]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Dec 14 17:37:39 UTC 2023
On Thu, 14 Dec 2023 17:06:05 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Implemented this renaming suggestion. Let's wait if Alan ia okay with it.
>
>> Implemented this renaming suggestion. Let's wait if Alan ia okay with it.
>
> Are you planning to drop the changes to mount/unmount too? They shouldn't be needed.
>
> notifyJvmtiCriticalLock(boolean) is okay for now but needs to be called before the try, not in the block. We have changes coming that will require moving these hooks to critical section enter/exit methods, so the naming will be less important then.
Yes, I've dropped changes in the mount/unmount methods.
I've already done renaming to `notifyJvmtiDisableSuspend(boolean)`.
Let's see if it is okay with you. It is not a problem to rename it back to `notifyJvmtiCriticalLock(boolean)`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17011#discussion_r1427032721
More information about the core-libs-dev
mailing list