RFR: 8322027: One XMLStreamException constructor fails to initialize cause

Archie Cobbs acobbs at openjdk.org
Thu Dec 14 20:10:40 UTC 2023


On Wed, 13 Dec 2023 20:06:03 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> One of the three `XMLStreamException` constructors that takes a `Throwable` fails to pass it to the superclass constructor.
> 
> This simple patch fixes that omission.
> 
> It's worth considering if there is any code out there that is working around this problem already by invoking `initCause()` manually. If so, that code would start throwing an `IllegalStateException` after this change.
> 
> So a more conservative fix would be to just add another constructor taking the same arguments in a different order. But then again that's not much better than just saying "always use initCause() with the broken constructor", i.e., don't change anything.
> 
> Hmm.

I agree - let's go the CSR route.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17090#issuecomment-1856510107


More information about the core-libs-dev mailing list