RFR: 6356745: Introduce constructor for PriorityQueue with existing collection and custom comparator [v2]

Pavel Rappo prappo at openjdk.org
Fri Dec 15 00:14:37 UTC 2023


On Thu, 14 Dec 2023 22:18:35 GMT, Valeh Hajiyev <duke at openjdk.org> wrote:

> @AlanBateman thanks for having a look. would you be able to create a CRS request as I don't have permission to do so?

You may not be able to create one, but you sure can look at some. If you do so, you'll see that obtaining a permission to create a [CSR](https://wiki.openjdk.org/display/csr/Main) is the least of your concerns. A CSR is a structured essay with elements of a checklist and it takes some effort to compose one. Here are some examples for you (feel free to look at more):

 - https://bugs.openjdk.org/browse/JDK-8189407
 - https://bugs.openjdk.org/browse/JDK-8284377
 - https://bugs.openjdk.org/browse/JDK-8287419
 - https://bugs.openjdk.org/browse/JDK-8266572
 - https://bugs.openjdk.org/browse/JDK-8191517

You've posted your suggestion on core-libs-dev and provided this essentially draft PR. Now simply wait for discussion, if any.

While waiting, though, consider how you would test your proposal. Generally, familiarise yourself with other PRs, both Open and Closed (in OpenJDK PRs are not Merged in GitHub sense). See how changes similar to what you propose are processed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17045#issuecomment-1857046857


More information about the core-libs-dev mailing list