RFR: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream [v3]

Archie Cobbs acobbs at openjdk.org
Fri Dec 15 16:30:01 UTC 2023


> `GZIPInputStream`, when looking for a concatenated stream, relies on what the underlying `InputStream` says is how many bytes are `available()`. But this is inappropriate because `InputStream.available()` is just an estimate and is allowed (for example) to always return zero.
> 
> The fix is to ignore what's `available()` and just proceed and see what happens. If fewer bytes are available than required, the attempt to extend to another stream is canceled just as it was before, e.g., when the next stream header couldn't be read.

Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:

  Address second round of review comments.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17113/files
  - new: https://git.openjdk.org/jdk/pull/17113/files/c7087e55..074b8455

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17113&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17113&range=01-02

  Stats: 40 lines in 1 file changed: 13 ins; 6 del; 21 mod
  Patch: https://git.openjdk.org/jdk/pull/17113.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17113/head:pull/17113

PR: https://git.openjdk.org/jdk/pull/17113


More information about the core-libs-dev mailing list