RFR: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles [v3]

Adam Sotona asotona at openjdk.org
Mon Dec 18 09:42:43 UTC 2023


On Sat, 16 Dec 2023 16:37:16 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply suggestions from code review
>>   
>>   Co-authored-by: liach <7806504+liach at users.noreply.github.com>
>
> src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java line 468:
> 
>> 466:     }
>> 467: 
>> 468:     private void emitStoreInsn(BasicType type, int index) {
> 
> If we are going to use `localsMap` in every removed `emitStoreInsn`, perhaps we should restore it instead? Will also make it easier to move away from localsMap to CodeBuilder's tracking system.

Right, I'll restore emitLoadInsn and emitStoreInsn

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17108#discussion_r1429791664


More information about the core-libs-dev mailing list