RFR: 8321688: Build on linux with GCC 7.5.0 fails after 8319577 [v2]

Kim Barrett kbarrett at openjdk.org
Mon Dec 18 15:31:41 UTC 2023


On Sun, 17 Dec 2023 13:25:00 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch fixes the building failure introduced by [JDK-8319577](https://bugs.openjdk.org/browse/JDK-8319577) in old GCC version (linux & GCC 7.5.0 locally).
>> 
>> Thanks for the review.
>> 
>>  Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Bump the needed version of GCC.
>  - Revert previous change.
>  - Merge branch 'master' into JDK-8321688
>  - JDK-8321688

src/java.base/linux/native/libsimdsort/simdsort-support.hpp line 35:

> 33: 
> 34: // GCC >= 9.1 is needed to build AVX2 portions of libsimdsort using C++17 features
> 35: #if defined(_LP64) && (defined(__GNUC__) && ((__GNUC__ > 9) || ((__GNUC__ == 9) && (__GNUC_MINOR__ >= 1))))

Have you tested with gcc 9?  Or is this just supposition based on gcc9 having removed the experimental
status for C++17?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17047#discussion_r1430308457


More information about the core-libs-dev mailing list