RFR: 8322417: Console read line with zero out should zero out when throwing exception

Naoto Sato naoto at openjdk.org
Tue Dec 19 17:31:49 UTC 2023


On Tue, 19 Dec 2023 12:47:53 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> …g exception
> 
> After leaving the method by throwing an exception the data can not be cleaned any more.

LGTM. Please remove the redundant package name before push.

src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 123:

> 121:                     }
> 122:                     if (ioe != null) {
> 123:                         java.util.Arrays.fill(passwd, ' ');

`java.util.` is redundant.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17156#pullrequestreview-1789389076
PR Review Comment: https://git.openjdk.org/jdk/pull/17156#discussion_r1431731882


More information about the core-libs-dev mailing list