RFR: JDK-8322141: SequenceInputStream.transferTo should not return as soon as Long.MAX_VALUE bytes have been transferred [v4]
Markus KARG
duke at openjdk.org
Wed Dec 20 22:49:58 UTC 2023
On Wed, 20 Dec 2023 18:49:39 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
> > this icon only says that Alan made change requests
>
> I think it's if the "changes requested" button is selected in the "Submit Review" popup under "Files Changed."
Typically yes. But not in the current case: Alan pressed "approve" first *without* giving a comment leading to this entry:

...then...

...and **after that** Alan pressed `Request changes` button in the review dialog (note the heading "Alan Bateman suggested changes last week"):

So the comment "I think jai is right" was the trigger to set that icon, but that icon was definitively **not** set before.
So I did not do something wrong but finally I learned Github forensics now. 😃
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17119#issuecomment-1865242504
More information about the core-libs-dev
mailing list