RFR: 8322322: Support archived full module graph when -Xbootclasspath/a is used [v2]

Alan Bateman alanb at openjdk.org
Sat Dec 23 08:11:46 UTC 2023


On Fri, 22 Dec 2023 18:33:59 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Please review this change for enabling full module graph even when -Xbootclasspath/a is specified. The validation of -Xbootclasspath/a is already being done in `FileMapInfo::validate_boot_class_paths()`. The full module graph will be disabled if there's a mismatch in -Xbootclasspath/a between dump time and runtime.
>> 
>> The changes in ClassLoaders.java is for setting up the append class path for the boot loader retrieved from the CDS archive. It is required because some existing tests are using the `getResourceAsStream()` api. Those tests would fail without the change.
>> 
>> Passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   comments from Alan and Ioi

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17178#pullrequestreview-1795413891


More information about the core-libs-dev mailing list