RFR: JDK-8300808: Accelerate Base64 on x86 for AVX2 [v7]

Scott Gibbons duke at openjdk.org
Wed Feb 1 21:02:31 UTC 2023


On Wed, 1 Feb 2023 20:53:54 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Handle AVX2 URL; address review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 2202:
> 
>> 2200: }
>> 2201: 
>> 2202: address StubGenerator::base64_AVX2_decode_URL_tables_addr() {
> 
> Shouldn't this be `decode_lut_tables`? As it's used for URL and non-URL decoding alike.

These tables are used for both URL and non-URL based on the parameter, and they are only two of the three lut tables used (the other is in `base64_AVX2_decode_tables_addr` ).  Both names are essentially incorrect.  Does the name really matter that much?  It's the same as `base64_AVX2_decode_tables_addr` with the addition of URL tables.

-------------

PR: https://git.openjdk.org/jdk/pull/12126


More information about the core-libs-dev mailing list