RFR: JDK-8301392: Port fdlibm log1p to Java [v5]

Joe Darcy darcy at openjdk.org
Thu Feb 2 18:06:00 UTC 2023


> Another day, another PR to port FDLBIM to Java, this time for the log1p method.
> 
> Other than using the two-argument form of the __HI method in Java transliteration version rather than C macro, there are no appreciable differences between the original C source in 
> 
> src/java.base/share/native/libfdlibm/s_log1p.c
> 
> and the transliteration for testing purposes in
> 
> test/jdk/java/lang/StrictMath/FdlibmTranslit.java
> 
> The more idiomatic port in
> 
> src/java.base/share/classes/java/lang/FdLibm.java
> 
> has had a series of transformation applied layering on the transliteration. The intermediate commits show the progress.
> 
> The regression tests include probing around input values the implementation uses to decided which branch to take.

Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:

  Refine test per code review feedback.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12301/files
  - new: https://git.openjdk.org/jdk/pull/12301/files/b3e028ac..7740edc9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12301&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12301&range=03-04

  Stats: 18 lines in 1 file changed: 4 ins; 4 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/12301.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12301/head:pull/12301

PR: https://git.openjdk.org/jdk/pull/12301


More information about the core-libs-dev mailing list