RFR: 8301226: Add clamp() methods to java.lang.Math and to StrictMath [v4]

[Joe Darcy]

On Mon, 6 Feb 2023 09:46:15 GMT, Tagir F. Valeev <tvaleev at openjdk.org> wrote:

>> clamp() methods added to Math and StrictMath
>> 
>> `int clamp(long, int, int)` is somewhat different, as it accepts a `long` value and safely clamps it to an `int` range. Other overloads work with a particular type (long, float and double). Using similar approach in other cases (e.g. `float clamp(double, float, float)`) may cause accidental precision loss even if the value is within range, so I decided to avoid this.
>> 
>> In all cases, `max >= min` precondition should met. For double and float we additionally order `-0.0 < 0.0`, similarly to what Math.max or Double.compare do. In double and float overloads I try to keep at most one arg-check comparison on common path, so the order of checks might look unusual.
>> 
>> For tests, I noticed that tests in java/lang/Math don't use any testing framework (even newer tests), so I somehow mimic the approach of neighbour tests.
>
> Tagir F. Valeev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added explanatory comments

test/jdk/java/lang/Math/Clamp.java line 47:

> 45:     private static int testIntClamp() {
> 46:         int failures = 0;
> 47:         failures += checkIntClamp(0, 1, 2, 1);

Possible refactoring here: represent the test cases in, say, a 2D int array or an array/list of records and loop over them.

-------------

PR: https://git.openjdk.org/jdk/pull/12428