RFR: 8301214: Adjust handshakeTimeout value in test HandshakeTimeout.java after 8189338 [v2]

Daniel Jeliński djelinski at openjdk.org
Tue Feb 7 09:38:13 UTC 2023


> Please review this patch that reduces the socket timeout used in HandshakeTimeout test to its minimum value of 1 millisecond.
> 
> This change makes the test complete 10 seconds faster; before this change it took 5 seconds for the handshake to timeout, and the test attempts 2 handshakes.
> 
> The change also makes the test more likely to pass when it has to compete with other tests for CPU time.

Daniel Jeliński has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Restructure test
 - Merge remote-tracking branch 'origin' into rmi-test-timeout
 - Reduce socket timeout

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12292/files
  - new: https://git.openjdk.org/jdk/pull/12292/files/8bad1d87..eaacd1e4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12292&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12292&range=00-01

  Stats: 16832 lines in 640 files changed: 7781 ins; 4227 del; 4824 mod
  Patch: https://git.openjdk.org/jdk/pull/12292.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12292/head:pull/12292

PR: https://git.openjdk.org/jdk/pull/12292


More information about the core-libs-dev mailing list