RFR: 8301214: Adjust handshakeTimeout value in test HandshakeTimeout.java after 8189338 [v2]
Vyom Tewari
vtewari at openjdk.org
Tue Feb 7 14:50:51 UTC 2023
On Tue, 7 Feb 2023 09:38:13 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> Please review this patch that reduces the socket timeout used in HandshakeTimeout test to its minimum value of 1 millisecond.
>>
>> This change makes the test complete 10 seconds faster; before this change it took 5 seconds for the handshake to timeout, and the test attempts 2 handshakes.
>>
>> The change also makes the test more likely to pass when it has to compete with other tests for CPU time.
>
> Daniel Jeliński has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Restructure test
> - Merge remote-tracking branch 'origin' into rmi-test-timeout
> - Reduce socket timeout
Refactored test looks good to me.
-------------
Marked as reviewed by vtewari (Committer).
PR: https://git.openjdk.org/jdk/pull/12292
More information about the core-libs-dev
mailing list