RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v2]

Matthew Donovan duke at openjdk.org
Tue Feb 7 20:38:45 UTC 2023


On Tue, 7 Feb 2023 20:10:47 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   clarified cases 4 and 5
>
> test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 184:
> 
>> 182:                 try {
>> 183:                     new ServerFactory(SSLContext.getDefault(),
>> 184:                             new String[]{"dummy_ciphersuite"}, null, false);
> 
> what if the constructor doesn't throw any exception? shouldn't the test fail? or should `run` be called in that case?

good catch; yes, the test should fail. I updated these cases.

-------------

PR: https://git.openjdk.org/jdk/pull/11910


More information about the core-libs-dev mailing list