RFR: 8301578: Perform output outside synchronization in Module.class [v4]

Per Minborg pminborg at openjdk.org
Thu Feb 9 16:30:45 UTC 2023


On Thu, 9 Feb 2023 15:19:38 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use Unsafe instead of synchronized
>
> src/java.base/share/classes/java/lang/Module.java line 120:
> 
>> 118:     // memory semantics that preserves ordering and visibility across threads.
>> 119:     //
>> 120:     // Used reflectively via Unsafe
> 
> I assume L119-120 can be removed.

The reson for the L119-120 comments is to make it easier to understand why we are declaring a variable that does not appear to be used. But maybe there is a better way to do that?

-------------

PR: https://git.openjdk.org/jdk/pull/12193


More information about the core-libs-dev mailing list