RFR: 8294961: java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes [v2]

Adam Sotona asotona at openjdk.org
Thu Feb 9 18:35:50 UTC 2023


On Wed, 8 Feb 2023 00:38:23 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - j.l.r.ProxyGenerator fix - Classfile API moved under jdk.internal.classfile package
>>  - Merge branch 'JDK-8294982' into JDK-8294961
>>  - Merge branch 'JDK-8294982' into JDK-8294961
>>  - 8294961: java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
>
> This looks good in general.   I like this, easy to use, easy to read and understand and greatly simplified.
> 
> Reviewing this is one easy way to study the ClassFile API.

@mlchung Thanks for the review and for the patch provided, I've applied it and going to push.
Thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/10991


More information about the core-libs-dev mailing list