RFR: 8294982: Implementation of Classfile API [v13]

Adam Sotona asotona at openjdk.org
Fri Feb 10 11:07:02 UTC 2023


On Tue, 7 Feb 2023 16:04:07 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - javadoc fixes
>>  - obsolete identifiers and unused imports cleanup
>>  - TypeAnnotation.TypePathComponent cleanup
>
> src/java.base/share/classes/jdk/internal/classfile/attribute/ModuleExportInfo.java line 107:
> 
>> 105:      * @param exportsTo the modules to which this package is exported
>> 106:      */
>> 107:     static ModuleExportInfo of(PackageEntry exports,
> 
> (Here and elsewhere) - should there be factories also taking a PackageDesc (which seems to be an extension of the ClassDesc API, but for packages) ?

yes, they are missing, I'm working on it.

-------------

PR: https://git.openjdk.org/jdk/pull/10982


More information about the core-libs-dev mailing list