RFR: 8302325: Wrong comment in java.base/share/native/libjimage/imageFile.hpp [v2]

[Severin Gehwolf]

On Tue, 14 Feb 2023 16:47:15 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jdk-8302325-imageFile
>>  - Copyright dates updated.
>>  - 8302325: Wrong comment in java.base/share/native/libjimage/imageFile.hpp
>
> src/java.base/share/native/libjimage/imageFile.hpp line 218:
> 
>> 216: // Notes:
>> 217: //  - Even though ATTRIBUTE_END is used to mark the end of the attribute stream,
>> 218: //      streams will contain non-zero byte values to represent lesser significant bits.
> 
> This change is not correct. Maybe it is badly worded but the point is that **zeroes can** occur in the stream so testing for zero is insufficient.

@JimLaskey OK. Perhaps we can be clearer what is meant here exactly. I was having a hard time deciphering this. It does say `stream will contain zero byte values to represent lesser significant bits`. **What** are "byte values to represent lesser significant bits"?

-------------

PR: https://git.openjdk.org/jdk/pull/12533