RFR: 8302325: Wrong comment in java.base/share/native/libjimage/imageFile.hpp [v2]

Severin Gehwolf sgehwolf at openjdk.org
Tue Feb 14 19:30:21 UTC 2023


On Tue, 14 Feb 2023 17:18:00 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jdk-8302325-imageFile
>>  - Copyright dates updated.
>>  - 8302325: Wrong comment in java.base/share/native/libjimage/imageFile.hpp
>
> Changes requested by jlaskey (Reviewer).

@JimLaskey How does this look to you now?

> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/PerfectHashBuilder.java line 249:
> 
>> 247:                     // Attempt to pack entries until no collisions occur.
>> 248:                     if (!collidedEntries(bucket, count)) {
>> 249:                         // Failed to pack. Need to grow table.
> 
> Change copyright date to mark this change.

Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/12533


More information about the core-libs-dev mailing list