RFR: JDK-8301460: Clean up LambdaForm to reference BasicType enums directly [v2]
Mandy Chung
mchung at openjdk.org
Tue Feb 14 19:36:48 UTC 2023
On Tue, 14 Feb 2023 10:50:12 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Mandy Chung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Merge branch 'master' of https://github.com/openjdk/jdk into JDK-8301460
>> - further clean up
>> - JDK-8301460: Code in LambdaForm.java still refers to resolved JDK-8161245
>
> src/java.base/share/classes/java/lang/invoke/BoundMethodHandle.java line 371:
>
>> 369: extensions[typeNum] = sd;
>> 370: return sd;
>> 371: }
>
> I suggest changing the existing overload to delegate to this one with `BasicType.basicType(typeNum)` as the argument. (or to use some other way to reduce the duplication)
I further cleaned this up. `extendWith(byte typeNum)` is now removed.
-------------
PR: https://git.openjdk.org/jdk/pull/12546
More information about the core-libs-dev
mailing list