RFR: 8294982: Implementation of Classfile API [v15]

Adam Sotona asotona at openjdk.org
Wed Feb 15 14:15:39 UTC 2023


On Thu, 9 Feb 2023 14:24:58 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/internal/classfile/instruction/ConstantInstruction.java line 63:
> 
>> 61:      * aload_0}).
>> 62:      */
>> 63:     sealed interface IntrinsicConstantInstruction extends ConstantInstruction
> 
> I'm not super sure of the fine-grained distinction here. The constant pool variant is interesting (as you can ask for the associated constant entry) - but the distinction between intrinsics vs. argument seems rather weak.

They significantly differ in instruction formats and instruction format distinction is critical for some use cases.

-------------

PR: https://git.openjdk.org/jdk/pull/10982


More information about the core-libs-dev mailing list