RFR: 8302158: PPC: test/jdk/jdk/internal/vm/Continuation/Fuzz.java: AssertionError: res: false shouldPin: false [v2]

Wed Feb 15 20:30:22 UTC 2023

On Wed, 15 Feb 2023 12:35:52 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Improve comment
>>  - Improve comment
>>  - Spelling
>
> src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp line 3094:
> 
>> 3092: 
>> 3093:   // Freezing continuation frames requires that the caller is trimmed to unextended sp if compiled.
>> 3094:   Register caller_sp = R23_tmp3;
> 
> Can the caller be interpreted? I.e., not compiled?
> Then it might be helpful to comment like
> // If not compiled this contains sp() resulting in a resize of 0.

Yes it can be interpreted. I've extended the comment for this case.

-------------

PR: https://git.openjdk.org/jdk/pull/12557