RFR: 8292914: Drop the counter from lambda class names [v4]
David M. Lloyd
duke at openjdk.org
Thu Feb 16 12:44:27 UTC 2023
On Thu, 16 Feb 2023 01:42:16 GMT, David M. Lloyd <duke at openjdk.org> wrote:
>> The class generated for lambda proxies is now defined as a hidden class. This means that the counter, which was used to ensure a unique class name and avoid clashes, is now redundant. In addition to performing redundant work, this also impacts build reproducibility for native image generators which might already have a strategy to cope with hidden classes but cannot cope with indeterminate definition order for lambda proxy classes.
>>
>> This solves JDK-8292914 by making lambda proxy names always be stable without any configuration needed. This would also replace #10024.
>
> David M. Lloyd has updated the pull request incrementally with two additional commits since the last revision:
>
> - Fix LambdaAsm test
> - Fix stack walker test
I definitely don't like that there is a map... maybe it'd be better to change the MH dumper to use the time stamp scheme instead? (In a separate change?)
-------------
PR: https://git.openjdk.org/jdk/pull/12579
More information about the core-libs-dev
mailing list