RFR: 8293667: Align jlink's --compress option with jmod's --compress option
Ian Graves
igraves at openjdk.org
Thu Feb 16 23:16:06 UTC 2023
On Mon, 9 Jan 2023 21:38:59 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> I skimmed through this (not a detailed review) and I think it's mostly okay. It's --compress 0 and 2 that should be listed as deprecated as --compress 1 is string sharing rather than zip compression.
>
>> I skimmed through this (not a detailed review) and I think it's mostly okay. It's --compress 0 and 2 that should be listed as deprecated as --compress 1 is string sharing rather than zip compression.
>
> I also think it's good to deprecate the old values. I think we can separate the StringSharingPlugin as a separate plugin option (e.g. `--compact-constant-pools`) and deprecate --compress 1 as well. Something like this:
>
>
> --compress <compress> Compression to use in compressing resources:
> Accepted values are:
> zip-[0-9], where zip-0 provides no
> compression, and zip-9 provides the
> best compression. Default is zip-6.
> Deprecated values:
> 0: No compression. Equivalent to zip-0.
> 1: Equivalent to --compact-constant-pools
> 2: Equivalent to zip-6.
Added additional changes per @mlchung 's suggestions. Thanks!
-------------
PR: https://git.openjdk.org/jdk/pull/11617
More information about the core-libs-dev
mailing list