RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v5]

Ian Graves igraves at openjdk.org
Fri Feb 17 03:13:31 UTC 2023


On Wed, 8 Feb 2023 13:27:09 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding plugin type to force compact strings vs zip ordering
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/CompactConstantPoolsPlugin.java line 44:
> 
>> 42: public final class CompactConstantPoolsPlugin extends AbstractPlugin implements ResourcePrevisitor {
>> 43: 
>> 44:     private static final String FILTER = "filter";
> 
> Should we perhaps just reference the already `public` `DefaultCompressPlugin.FILTER` field instead of redefining it here?

Good catch. Test is removed but appreciate it!

-------------

PR: https://git.openjdk.org/jdk/pull/11617


More information about the core-libs-dev mailing list