RFR: 8292914: Drop the counter from lambda class names [v7]

[David M. Lloyd]

> The class generated for lambda proxies is now defined as a hidden class. This means that the counter, which was used to ensure a unique class name and avoid clashes, is now redundant. In addition to performing redundant work, this also impacts build reproducibility for native image generators which might already have a strategy to cope with hidden classes but cannot cope with indeterminate definition order for lambda proxy classes.
> 
> This solves JDK-8292914 by making lambda proxy names always be stable without any configuration needed. This would also replace #10024.

David M. Lloyd has updated the pull request incrementally with one additional commit since the last revision:

  Updated to use hidden class suffix for dumps when possible, else use the counter with a `failed` suffix. Also, remove the extra trailing `$` from the lambda class name and update tests accordingly.
  
  This combines the suggestions made by @mlchung and @ExE-Boss and hopefully will resolve the Windows testing issue.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12579/files
  - new: https://git.openjdk.org/jdk/pull/12579/files/e9d1d7f2..a9d0acc3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12579&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12579&range=05-06

  Stats: 63 lines in 4 files changed: 34 ins; 16 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/12579.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12579/head:pull/12579

PR: https://git.openjdk.org/jdk/pull/12579