RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v3]

Stuart Marks smarks at openjdk.org
Fri Feb 17 20:00:00 UTC 2023


On Tue, 7 Feb 2023 20:38:40 GMT, Matthew Donovan <duke at openjdk.org> wrote:

>> Removed SSLSocketParametersTest.sh script (which just called a Java file) and configured the java code to run directly with jtreg
>
> Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   added exceptions for cases 4 and 5

General comments: the ClientFactory, ServerFactory, and HelloClient classes don't seem to be adding much value. Also, the setup of the HelloImpl service could probably be simplified by not having it extend UnicastRemoteObject and instead calling UnicastRemoteObject.exportObject(). These are held over from the original test and don't have much do with the shell script conversion, though, so you might choose not to undertake these cleanups now. But if you're interested, let me know and we can discuss them further.

-------------

PR: https://git.openjdk.org/jdk/pull/11910


More information about the core-libs-dev mailing list