RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v3]

Roger Riggs rriggs at openjdk.org
Fri Feb 17 20:00:04 UTC 2023


On Fri, 17 Feb 2023 19:53:10 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added exceptions for cases 4 and 5
>
> test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 211:
> 
>> 209:                         throw exc;
>> 210:                     }
>> 211:                 }
> 
> Having exception handling in the run() method and also in this switch statement is quite confusing. It obscures the fact that these cases (4 and 5) don't call run() at all. It would be good to find a structure that makes it clear that some test cases are for exceptions that occur at ServerFactory creation time and other exceptions occur when an actual socket connection is attempted.

Perhaps some refactoring should be done in a separate PR. 
The stated goal was to remove the use of the shell script; but its easy to start to refactor more and more.

-------------

PR: https://git.openjdk.org/jdk/pull/11910


More information about the core-libs-dev mailing list