RFR: 8302667: Improve message format when failing to load symbols or libraries [v2]

Mandy Chung mchung at openjdk.org
Tue Feb 21 17:02:28 UTC 2023


On Fri, 17 Feb 2023 14:08:34 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> DLL_ERROR4 is a macro expanding to an error message when a failure to load a generic item (shared libraries or an exported symbol from said libraries for example) occurs. "Error: loading:" is not a very pretty message, so this small change results in "Error: Failed to load %s" instead, which looks better and also means the message makes more sense if we want to append a reason behind as well, such as "Error: Failed to load libjvm.so because xxx"
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-6
>  - Error: Failed to load

What about:


#define ARG_ERROR18      "Error: reading %s"

-------------

PR: https://git.openjdk.org/jdk/pull/12596


More information about the core-libs-dev mailing list