RFR: 8302899: Executors.newSingleThreadExecutor can use Cleaner to shutdown executor

Martin Buchholz martin at openjdk.org
Tue Feb 21 17:05:29 UTC 2023


On Mon, 20 Feb 2023 18:34:17 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> Executors.newSingleThreadExecutor returns a delegating ExecutorService that has finalizer to shutdown the underlying TPE when the wrapper is finalizable. It goes back to JDK 6 and JDK-6399443. This is the last non-empty finalizer in java.base. Removing it will likely lead to bug reports/complaints as the current behavior goes back to 2006. So the proposal is to just replace it with a Cleaner, trivially done in this case. As part of the changes, I've replaced the existing test with a more modern test that exercises more scenarios.

Changes requested by martin (Reviewer).

test/jdk/java/util/concurrent/Executors/AutoShutdown.java line 115:

> 113: 
> 114:     /**
> 115:      * Returns the delegates for the given ExecutorService. The given ExectorService

typo: ExectorService

-------------

PR: https://git.openjdk.org/jdk/pull/12675


More information about the core-libs-dev mailing list