RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v4]

[Stuart Marks]

On Fri, 17 Feb 2023 20:41:16 GMT, Matthew Donovan <duke at openjdk.org> wrote:

>> Removed SSLSocketParametersTest.sh script (which just called a Java file) and configured the java code to run directly with jtreg
>
> Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - added System.exit when exceptions are thrown and refactored for clarity
>  - Merge branch 'master' into rmi-sslparams
>  - added default switch case and additional refactoring
>  - added exceptions for cases 4 and 5
>  - clarified cases 4 and 5
>  - 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test

test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 151:

> 149:                 throw new RuntimeException("An error occurred during test execution", exc);
> 150:             } else {
> 151:                 System.out.println("Caught expected exception: " + exc);

I'm not quite clear on what the expected exception actually is -- is it an IllegalArgumentException or an IOException? Or does it differ from case to case? It would be good to be precise about exactly which exception is expected to be thrown from which test case. If IOException is caught here only because it's declared to be thrown by some method, and it's incidental to the test, I'd suggest it be propagated. (See my similar comments on testServerFactory.)

-------------

PR: https://git.openjdk.org/jdk/pull/11910