RFD: Invalid CRC in ZipFile, ZipFileSystem

Eirik Bjørsnøs eirbjo at gmail.com
Thu Feb 23 12:43:15 UTC 2023


Hi,

While writing various ZIP related tests, I noticed a discrepancy in the
treatment of invalid CRC values:

While ZipInputStream rejects invalid CRC values when consuming streams,
ZipFile and ZipFileSystem do not.

While this is inconsistent, it is perhaps not a bug we want to fix?

In any case, it could perhaps be good to have better test coverage in this
area. Here's a test which validates the current behaviour of ZIS, ZF and
ZFS:

https://github.com/openjdk/jdk/compare/master...eirbjo:jdk:zip-invalid-crc

Any thoughts?

Thanks,
Eirik.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/core-libs-dev/attachments/20230223/c46e76f0/attachment.htm>


More information about the core-libs-dev mailing list