RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v12]

Mandy Chung mchung at openjdk.org
Thu Feb 23 23:29:09 UTC 2023


On Thu, 23 Feb 2023 19:04:33 GMT, Ian Graves <igraves at openjdk.org> wrote:

>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/DefaultCompressPlugin.java line 96:
>> 
>>> 94:             switch (level) {
>>> 95:                 case LEVEL_0:
>>> 96:                     System.err.println(getMessage("warn.prefix") + " " +
>> 
>> Suggestion:
>> 
>>                     System.err.println(getMessage("compress.warn.argumentdeprecated", level));
>> 
>> 
>> It can be simpler to out the warning prefix in the message.  Same for line 102 and 107.
>
> That works for me.

I saw you updated plugins.properties but you miss this change.

-------------

PR: https://git.openjdk.org/jdk/pull/11617


More information about the core-libs-dev mailing list