RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v2]

Raffaello Giulietti rgiulietti at openjdk.org
Fri Feb 24 17:48:11 UTC 2023


On Fri, 24 Feb 2023 17:40:52 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/String.java line 2462:
>> 
>>> 2460:      *
>>> 2461:      * <p>There are no restrictions on the value of {@code fromIndex} and
>>> 2462:      * {@code toIndex}. Negative values have the same effect as it they were zero.
>> 
>> "as it" -> "as if"
>
> addressed

JMH does not indicate any performance regression.

W.r.t. renaming Java parameters in `@IntrinsicCandidate` methods, I crosschecked with a runtime compiler guy. He confirms that changing names in the Java implementations is irrelevant for the intrinsified code. There might be references to the names in native comments, but this is not the case for `indexOf`. However, to be on the safe side I reverted those renames back to the original.

-------------

PR: https://git.openjdk.org/jdk/pull/12600


More information about the core-libs-dev mailing list