RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider
Madjosz
duke at openjdk.org
Fri Feb 24 19:38:05 UTC 2023
On Wed, 22 Feb 2023 20:41:07 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Fixes JDK-8302983 (and duplicate JDK-8302898)
>
> test/jdk/java/time/test/java/time/zone/TestZoneRulesProvider.java line 123:
>
>> 121: ZoneRulesProvider.registerProvider(provider);
>> 122: assertTrue(ZoneId.getAvailableZoneIds().contains(zone), "Unexpected non-availability for " + zone);
>> 123: assertNotNull(ZoneId.of(zone), "ZoneId instance for " + zone + " should be obtainable");
>
> If the `zone` does not exist, it will not return `null` but throw an exception. Assertion needs to be modified correctly.
Which version of TestNG is used for JDK? In JUnit 5 I would just use `assertDoesNotThrow()` in such a case but TestNG seems to lack such method.
-------------
PR: https://git.openjdk.org/jdk/pull/12690
More information about the core-libs-dev
mailing list