RFR: 8294982: Implementation of Classfile API [v20]

[Adam Sotona]

On Thu, 16 Feb 2023 10:54:00 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/components/ClassPrinter.java line 140:
> 
>> 138: 
>> 139:     /**
>> 140:      * A tree node holding {@link List} of nested nodes.
> 
> It would perhaps be beneficial to have little examples of what these different nodes are used for. I had to look at `ClassPrinterImpl` to get some idea.

I'll link examples from package-info here.

> src/java.base/share/classes/jdk/internal/classfile/impl/ClassPrinterImpl.java line 745:
> 
>> 743:                     list("stack", "item", Stream.of())));
>> 744:             }
>> 745:             var excHandlers = com.exceptionHandlers().stream().map(exc -> new ExceptionHandler(com.labelToBci(exc.tryStart()), com.labelToBci(exc.tryEnd()), com.labelToBci(exc.handler()), exc.catchType().map(ct -> ct.name().stringValue()).orElse(null))).toList();
> 
> Watch out for very long lines

wil fix it, thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/10982