RFR: 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed. [v3]

Leonid Mesnik lmesnik at openjdk.org
Mon Feb 27 17:48:40 UTC 2023


> The solution proposed by Stefan K
> 
> The startProcess() might wait forever for the expected line if the process exits (failed to start). It makes sense to just fail earlier in such cases.
> 
> The fix also move
> 'output = new OutputAnalyzer(this.process);'
> in method xrun() to be able to try to print them in waitFor is failed/interrupted.

Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:

  fixed conditions.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12751/files
  - new: https://git.openjdk.org/jdk/pull/12751/files/890dcc34..5b7e3897

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12751&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12751&range=01-02

  Stats: 19 lines in 2 files changed: 4 ins; 12 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/12751.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12751/head:pull/12751

PR: https://git.openjdk.org/jdk/pull/12751


More information about the core-libs-dev mailing list