RFR: 8303266: Prefer ArrayList to LinkedList in JImageTask

Jim Laskey jlaskey at openjdk.org
Mon Feb 27 21:16:02 UTC 2023


On Mon, 27 Feb 2023 11:33:38 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> `LinkedList` is used as a field `jdk.tools.jimage.JImageTask.OptionsValues#jimages`
> It's created, filled (with `add`) and then iterated. No removes from the head or something like this. `ArrayList` should be preferred as more efficient and widely used (more chances for JIT) collection.

LGTM. Not sure why he used that but may have started with a linked list hashmap to track duplicate files and the dropped down to linked list. At any rate, should be fine.

-------------

Marked as reviewed by jlaskey (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12760


More information about the core-libs-dev mailing list