RFR: 8299576: Reimplement java.io.Bits using VarHandle access [v2]

Uwe Schindler uschindler at openjdk.org
Wed Jan 4 09:28:48 UTC 2023


On Wed, 4 Jan 2023 09:01:06 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> Currently, `java.io.Bits` is using explicit logic to read/write various primitive types to/from byte arrays. Switching to the use of `VarHandle` access would provide better performance and less code. 
>> 
>> Also, using a standard API for these conversions means future `VarHandle` improvements will benefit `Bits` too. 
>> 
>> Improvements in `Bits` will propagate to `ObjectInputStream`, `ObjectOutputStream` and `RandomAccessFile`.
>> 
>> Initial benchmarks and performance discussions can be found here: https://github.com/openjdk/panama-foreign/pull/762
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year in test class

Do we need this test at all, because this code is tested to extense through RandomAccessFile? We had no test before, so why add a new one here?

Otherwise: PR looks good.

-------------

PR: https://git.openjdk.org/jdk/pull/11840


More information about the core-libs-dev mailing list