RFR: 8258776: ThreadLocal#initialValue() Javadoc is unaware of ThreadLocal#withInitial() [v2]

Jaikiran Pai jpai at openjdk.org
Thu Jan 5 13:24:10 UTC 2023


On Wed, 4 Jan 2023 20:14:14 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review suggestion
>
> src/java.base/share/classes/java/lang/ThreadLocal.java line 128:
> 
>> 126:      * value other than {@code null}, then either {@code ThreadLocal} can be
>> 127:      * subclassed and this method overridden or {@link ThreadLocal#withInitial(Supplier)} method
>> 128:      * can be used to construct a {@code ThreadLocal}.
> 
> This looks okay but maybe slightly better to say "or the method withInitial(Supplier) can be used ...". 
> 
> I think you can probably reflow this paragraph to avoid having a mix of short and long lines.

Hello Alan, I've updated this PR with this suggested change and also formatted this new text to avoid having a mix of long and short lines.

-------------

PR: https://git.openjdk.org/jdk/pull/11846


More information about the core-libs-dev mailing list