RFR: 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs

Lance Andersen lancea at openjdk.org
Fri Jan 6 21:36:51 UTC 2023


On Fri, 6 Jan 2023 21:20:45 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> src/java.xml/share/classes/javax/xml/stream/XMLOutputFactory.java line 59:
>> 
>>> 57:  *
>>> 58:  * <p>The property can be set with the following code line:
>>> 59:  * {@code setProperty("javax.xml.stream.isRepairingNamespaces", Boolean.TRUE|Boolean.FALSE);}
>> 
>> From a code standpoint I don't see why the OR operation is needed (Also, shouldn't a Conditional OR be used over a Bitwise OR). Is it to emphasize that true _or_ false can be passed as a parameter?
>
> I think the later, that the value can be true or false. As an example, one value is fine, e.g.
>   {@code setProperty("javax.xml.stream.isRepairingNamespaces", Boolean.TRUE);} 
>   or 
>   {@code setProperty("javax.xml.stream.isRepairingNamespaces", true);}
>   let autoboxing handle it.

The` true|false` should just be changed to just set the value to _true_ or _false_.

I think `Boolean.TRUE` is fine.   If the consensus is to use autoboxing in the example that is fine also.

-------------

PR: https://git.openjdk.org/jdk/pull/11872


More information about the core-libs-dev mailing list